Heuristics to fix interop with bad ZeroChecksum #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCTP implementation used in v3.2.28 fails to establish a connection with other WebRTC implementations. The implementation of ZeroChecksum assumes incorrectly that the feature is bi-directional SCTP ZeroChecksum is actually a uni-directional feature which causes the Assocations to be unable to communicate.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
===========================================
- Coverage 81.13% 67.38% -13.76%
===========================================
Files 49 49
Lines 4188 4194 +6
===========================================
- Hits 3398 2826 -572
- Misses 647 1207 +560
- Partials 143 161 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidzhao
added a commit
to livekit/livekit
that referenced
this pull request
Apr 3, 2024
davidzhao
added a commit
to livekit/livekit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCTP implementation used in v3.2.28 fails to establish a connection with other WebRTC implementations. The implementation of ZeroChecksum assumes incorrectly that the feature is bi-directional
SCTP ZeroChecksum is actually a uni-directional feature which causes the Assocations to be unable to communicate.